Page 1 of 1

Problem with event "Capital Defenses Beefed Up!"

Posted: Mon Sep 19, 2016 8:52 pm
by BigDuke66
Hi
I got a problem with the event "Capital Defenses Beefed Up!".
The problem is that Alexandria isn't in the hands of the Union anymore, still a stack of Union units formed there.
I guess what is needed is a separate event for Washington & Alexandria, and the events can only fire if at least the structure is still in the Union hands, better if the region has at least a military control off +50% because I don't see how units can be formed if the regions of Washington and/or Alexandria are lost and only the structures are besieged.
Cheers

Posted: Sat Sep 24, 2016 3:10 am
by grimjaw
This is a problem with many of the events; no ownership/loyalty check of regions before firing. It's particularly bad in the national capitals, where generals and units will continue to spawn long after the region has been captured.

Posted: Sat Sep 24, 2016 1:29 pm
by Teatime
Indeed .. some events are straight up without checks .. e.g the BeefedUpDefences events

SelectFaction = USA
SelectRegion = $Prince_George_MD

Where as a lot of events have checks for MC such as the first 1861 US generals event

SelectFaction = USA
StartEvent = evt_nam_USA_1861Generals|1|1|NULL|NULL|NULL|NULL

Conditions
MinDate = 1861/04/16
MaxDate = 1861/06/30

Actions
SelectRegion = $Prince_George_MD
PickFromRegList = NotEnemy;NotAdj
GenMsg
SelectRegInArea = $MD;Squared;OwnedCities;CondSkip
GenMsg
SelectRegion = $Philadelphia_PA;CondSkip
PickFromRegList = NotEnemy
GenMsg

unfortunately the checklists are not fully implemented, particularly for border areas, so you get some strange events.

Not sure checklists for all events would make sense .. The Alexandria defense forces could be placed in Washington, as an alternative, but if that has fallen then the next logical place would be New York or Philly?

Posted: Sat Sep 24, 2016 1:45 pm
by PhilThib
I am investigating the issue

Posted: Sun Sep 25, 2016 3:05 am
by Teatime
I am happy to have a look through the events and list the ones that perhaps could be enhanced. I have some spare time at the moment.

I have noticed that the David Porter event also looks to have a syntax error as i think that event is meant to place him in Cairo unless it is occupied but instead puts him in a random open Illinois harbour.

Posted: Wed Oct 05, 2016 2:37 pm
by PhilThib
BigDuke66 wrote:Hi
I got a problem with the event "Capital Defenses Beefed Up!".
The problem is that Alexandria isn't in the hands of the Union anymore, still a stack of Union units formed there.
I guess what is needed is a separate event for Washington & Alexandria, and the events can only fire if at least the structure is still in the Union hands, better if the region has at least a military control off +50% because I don't see how units can be formed if the regions of Washington and/or Alexandria are lost and only the structures are besieged.
Cheers


I am surprised by the report, can you give us a save. The concerned event only creates 2 Union stacks, and both of them are inside Washington DC, and nowhere next or in Alexandria, VA. Therefore the fault can't come from the event. I would really need a save and a picture screen, maybe there are other sides effects to the event we have not yet seen.

Posted: Wed Oct 05, 2016 5:29 pm
by BigDuke66
Sorry no save, been too long and there is no backup save anymore.
But when I check USA Events.sct and there is an event called CapitalDefensesBeefedUp1861 and that looks like this:

SelectFaction = USA
SelectRegion = $Prince_George_MD
StartEvent = evt_nam_USA_CapitalDefensesBeefedUp1861|1|2|evt_txt_USA_CapitalDefensesBeefedUp1861|Event-img_USA_SouthernUnionists1861|$Prince_George_MD|11

Conditions
MinDate = 1861/11/15
MaxDate = 1862/01/01

Actions
DescEvent = evt_desc_USA_CapitalDefensesBeefedUp1861
ChangeFacMorale = 1
ChangeConscriptPool = 10

SelectFaction = USA
SelectRegion = $Prince_George_MD
CreateGroup
Posture = $Defensive
SetKind = $Land
Entranch = 4
InCS = 1
FixType = 60
SetName = Washington Defense Force
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. Y. Sullivan
SUFlavorName = 3rd MD Vol.|4th MD Vol.|Columbia Rifles
SetName = 2nd Maryland Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. B. Gates
SUFlavorName = 5th MD Vol.|6th MD Vol.|Patuxent Rifles
SetName = 3rd Maryland Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. H. Jesup
SUFlavorName = 3rd NJ Vol.|4th NJ Vol.|Trenton Blues
SetName = 2nd New Jersey Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. P. Ward
SUFlavorName = 3rd RI Vol.|4th RI Vol.|Newport Rifles
SetName = 1st Rhode Island Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. T. Soul
SUFlavorName = 3rd DE Vol.|4th DE Vol.|Dover Rifles
SetName = 2nd Delaware Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. F. McNamara
SUFlavorName = 3rd NY Vol.|4th NY Vol.|West Point Rifles
SetName = 4th New York Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. H. Kilpatrick
SUFlavorName = 3rd VT Vol.|4th VT Vol.|Montpellier Rifles
SetName = 2nd Vermont Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. R. Jackson
SUFlavorName = 3rd MA Vol.|4th MA Vol.|Charlestown Rifles
SetName = 3rd Massachussetts Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. S. Carter
SUFlavorName = 3rd ME Vol.|4th ME Vol.|Portland Rifles
SetName = 2nd Maine Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. M. Tumbs
SUFlavorName = 3rd WV Vol.|4th WV Vol.|Wheeling Rifles
SetName = 2nd West Virginia Volunteers
Apply

SelectRegion = $Fairfax_VA

SelectFaction = USA
SelectRegion = $Fairfax_VA
CreateGroup
Posture = $Defensive
SetKind = $Land
Entranch = 4
InCS = 1
FixType = 60
SetName = Alexandria Defense Force
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. U. Terry
SUFlavorName = 1st VA Vol.|2nd VA Vol.|Alexandria Rifles
SetName = 1st Virginia Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. C. Higgins
SUFlavorName = 3rd VA Vol.|4th VA Vol.|Manassas Rifles
SetName = 2nd Virginia Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. R. Masters
SUFlavorName = 3rd CT Vol.|4th CT Vol.|Hartford Rifles
SetName = 2nd Connecticut Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. E. Gould
SUFlavorName = 3rd OH Vol.|4th OH Vol.|Cleveland Rifles
SetName = 3rd Ohio Volunteers
Apply
CreateUnit
SetType = $uni_USA_VolBde
FlavorName = Col. W. Hill
SUFlavorName = 3rd MI Vol.|4th MI Vol.|Macomb Rifles
SetName = 3rd Michigan Volunteers
Apply

EndEvent

The lower bold part is for Fairfax.

Posted: Thu Oct 06, 2016 7:09 am
by PhilThib
Something is weird then, because the original Excel sources (from Dec 2013) don't have the bottom part. Can you give me the date of the change (file date), looks like this was not added by me, or it is an old file copy/paste.

Posted: Thu Oct 06, 2016 8:05 am
by BigDuke66
Date of change is 11th April 2014.

Re: Problem with event "Capital Defenses Beefed Up!"

Posted: Fri Mar 23, 2018 4:29 pm
by BigDuke66
As this is still there in 1.0.6.3 here a save before and after turn processing.
Replay files are removed as the archive would be too big to upload, hope this is no problem.