Page 1 of 1

Error in USADistantBlockades

Posted: Sat Dec 21, 2013 3:58 am
by Keeler
I was looking over this file (thanks aaminoff) and I caught this:

SelectFaction = USA
SelectRegion = $Ft_Morgan_AL
StartEvent = USA_DistantBlockade_FtMorgan|999|0|NULL|NULL|$Ft_Morgan_AL|NULL

Conditions

EvalRgnOwned = $Ft_Morgan_AL

Actions
SetDistantBlockades = $Ft_Morgan_AL;$Mobile_VA

EndEvent


Mobile is tagged as $Mobile_VA. Shouldn't it be $Mobile_AL ?

Posted: Sat Dec 21, 2013 10:57 am
by PhilThib
Good point indeed. Will be fixed. Thanks

Posted: Sat Dec 21, 2013 1:13 pm
by aaminoff
While on this file, as I pointed out in the other thread, there is City Point and Suffolk also on the James River behind Ft Monroe. Possibly City Point is not listed because (according to the list in that thread) it has no blockade-effect value anyway, but Suffolk should in principle be included.

Posted: Sun Dec 22, 2013 2:48 pm
by aaminoff
Does anyone at AGEOD program in perl at all?

while(<>) {
/\$(\S+_[A-Z]{2})/ and $seen{$1}++;
}
foreach $region ( sort { $seen{$a} <=> $seen{$b} } keys %seen ) {
print $region,"\t",$seen{$region},"\n";
}


This will print all the names of regions that end in a 2-uppercase-letter state code sorted by the number of times they appear. You can then look at the least frequent ones and those will most likely be typos. You could do this one file at a time or across the whole directory.

I'm just dashing this off in a forum post, tweaks might be needed to the regexp.